Skip to content

Commit

Permalink
fix: updated node dependencies
Browse files Browse the repository at this point in the history
  • Loading branch information
ethanneff committed Jun 19, 2017
1 parent 2eaff07 commit 5c59d53
Show file tree
Hide file tree
Showing 3 changed files with 465 additions and 258 deletions.
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,18 +46,18 @@
"dependencies": {
"mkpath": "^1.0.0",
"node-version-compare": "^1.0.1",
"plist": "^2.0.1",
"plist": "^2.1.0",
"xml2js": "^0.4.17"
},
"devDependencies": {
"gulp": "^3.9.1",
"gulp-standard": "^9.0.0",
"husky": "^0.13.2",
"gulp-standard": "^10.0.0",
"husky": "^0.13.4",
"mkpath": "^1.0.0",
"node-version-compare": "^1.0.1",
"plist": "^2.1.0",
"semantic-release": "^6.3.6",
"validate-commit-msg": "^2.11.2",
"validate-commit-msg": "^2.12.2",
"xml2js": "^0.4.17"
}
}
16 changes: 5 additions & 11 deletions src/scripts/npm/downloadNpmDependencies.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,10 @@
var modules = getNodeModulesToInstall(dependencies)
if (modules.length === 0) return async.promise

installNodeModules(modules, function (err) {
if (err) {
// handle error
throw new Error('BRANCH SDK: Failed to install the Branch SDK. Docs https://goo.gl/GijGKP')
} else {
// only run once
setPackageInstalled(installFlagLocation)
removeEtcDirectory()
}
installNodeModules(modules, function () {
// only run once
setPackageInstalled(installFlagLocation)
removeEtcDirectory()
async.resolve()
})

Expand All @@ -47,7 +42,7 @@
function installNodeModules (modules, callback) {
// base case
if (modules.length <= 0) {
return callback(false)
return callback()
}

// install one at a time
Expand All @@ -58,7 +53,6 @@
exec(install, function (err, stdout, stderr) {
// handle error
if (err) {
callback(true)
throw new Error('BRANCH SDK: Failed to install Branch node dependency ' + module + '. Docs https://goo.gl/GijGKP')
} else {
// next module
Expand Down
Loading

0 comments on commit 5c59d53

Please sign in to comment.