Skip to content

Commit

Permalink
fix: android-prefix now required for custom domains
Browse files Browse the repository at this point in the history
  • Loading branch information
ethanneff committed May 23, 2017
1 parent 5661e0a commit d4417ac
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -598,7 +598,7 @@
<link-domain value="bnc.lt" /> <!-- optional previous link domain -->
<ios-team-release value="PW4Q8885U7" /> <!-- required if iOS app -->
<ios-team-debug value="FG35JLLMXX" /> <!-- optional -->
<android-prefix value="/WSuf" /> <!-- optional (for bnc.lt) -->
<android-prefix value="/WSuf" /> <!-- optional (for bnc.lt and custom domains) -->
<android-testmode value="true" /> <!-- optional (simulate installs) -->
</branch-config>
```
Expand Down
7 changes: 2 additions & 5 deletions src/scripts/android/updateAndroidManifest.js
Original file line number Diff line number Diff line change
Expand Up @@ -195,15 +195,12 @@

intentFilterData.push(getAppLinkIntentFilterDictionary(linkDomain))
intentFilterData.push(getAppLinkIntentFilterDictionary(alternate))
} else if (linkDomain.indexOf('bnc.lt') !== -1) {
// bnc.lt
} else {
// bnc.lt and custom domains
if (preferences.androidPrefix === null) {
throw new Error('BRANCH SDK: Invalid "android-prefix" in <branch-config> in your config.xml. Docs https://goo.gl/GijGKP')
}
intentFilterData.push(getAppLinkIntentFilterDictionary(linkDomain, preferences.androidPrefix))
} else {
// custom
intentFilterData.push(getAppLinkIntentFilterDictionary(linkDomain))
}
}

Expand Down

0 comments on commit d4417ac

Please sign in to comment.