Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setDebug has no effect #14

Closed
ripcurlx opened this issue Sep 28, 2015 · 6 comments
Closed

setDebug has no effect #14

ripcurlx opened this issue Sep 28, 2015 · 6 comments
Assignees
Labels

Comments

@ripcurlx
Copy link

Hi!

I'm trying to activate the debug mode by setting branch.setDebug before branch.init, but it doesn't make any difference and only tracks a open instead of an install. I've stepped into it with the debugger and the debug flag is set properly. Unfortunately the compressed google closure code isn't very easy to debug.
It seems to be as if an install tracking is sent to branch backend:
https://api.branch.io/v1/install
request:

sdk:    cordova1.7.0
hardware_id:    [HARDWARE_ID]
is_hardware_id_real:    true
app_version:    [APP VERSION]
brand:  Apple
model:  iPad4,1
os: iOS
uri_scheme: [URI_SCHEME]
os_version: 8.4
screen_width:   2048
screen_height:  1536
is_referrable:  1
branch_key: [BRANCH_KEY]

response:

{
    "session_id": "[SESSION_ID]",
    "identity_id": "[IDENTITIY_ID]",
    "device_fingerprint_id": "[DEVICE_FINGERPRINT_ID]",
    "browser_fingerprint_id": null,
    "link": "https://bnc.lt/j/JVz0WDSvum",
    "identity": "1020",
    "data": "{\"$desktop_url\":\"http://www.desktopurl.com\",\"$marketing_title\":\"Test Install\",\"$one_time_use\":false,\"~campaign\":\"install\",\"~channel\":\"Landingpage\",\"~creation_source\":\"Dashboard\",\"~feature\":\"marketing\",\"~id\":\"176980187282456102\",\"+match_guaranteed\":true,\"+click_timestamp\":1443435811,\"+is_first_session\":false,\"+clicked_branch_link\":true}"
}

Also the trick to add a debug device for a cordova based app somehow doesn't work. Is there a way to do this manually, besides the four finger press trick?

Best

Christoph

@Kirkkt
Copy link
Contributor

Kirkkt commented Sep 29, 2015

Indeed, reading the code https://github.com/BranchMetrics/Smart-App-Banner-Deep-Linking-Web-SDK/blob/master/src/6_branch.js#L249 setDebug doesn't seem to actually do anything for Cordova.

We are low on man power at this moment so I will list this as low-pri.

Thanks for reporting the bug! I will let you know when I can get on with it.

@Kirkkt Kirkkt added the bug label Sep 29, 2015
@Kirkkt Kirkkt self-assigned this Sep 29, 2015
@ripcurlx
Copy link
Author

Thanks for looking into it @Kirkkt! I think it only doesn't work on iOS. On Android it is passed through to the getUniqueID call, where a random androidID is generated every time. Still the four finger trick only works with the native SDKs.

@ripcurlx
Copy link
Author

Just had time to check the Android part of it. It's the same problem as with the iOS version.

@edanchenkov
Copy link

That's what we really need ASAP !

@jsaleigh jsaleigh assigned jsaleigh and unassigned Kirkkt Oct 28, 2015
jsaleigh pushed a commit that referenced this issue Oct 29, 2015
Added debug_set value to return value during a fresh install
@jsaleigh
Copy link
Contributor

Hi @ripcurlx, sorry this took so long to get fixed, but the setDebug code should be working for you now on iOS and Android. Please let me know if you see any problems using it now.

@aaustin
Copy link
Contributor

aaustin commented Dec 22, 2015

This was resolved in recent version.

@aaustin aaustin closed this as completed Dec 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants