Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed leaflet to leaflet_id #101

Merged
merged 2 commits into from
Dec 6, 2024
Merged

changed leaflet to leaflet_id #101

merged 2 commits into from
Dec 6, 2024

Conversation

JesseSandberg
Copy link
Contributor

@JesseSandberg JesseSandberg commented Dec 5, 2024 •
edited by JahmalEnnis
Loading

Description

Rename leaflet to leaflet_id

Usage Changes

name of attribute has changed

Todos

Notable points that this PR has either accomplished or will accomplish.

  • renamed leaflet to leaflet_id
  • replaced all instances of leaflet with leaflet_id in Site and Symmetric_Site
  • checked all other files to make sure no other references

Pre-Review checklist (PR maker)

  • New configuration parameters are documented (Usage changes above)

Review checklist (Reviewer)

  • No missed "low-hanging fruit" that would substantially aid readability.
  • Any "high-hanging" or "rotten" fruit is added to the issues list.
  • I understand what the changes are doing and how
  • I understand the motivation for this PR (the PR itself is appropriately documented)

Status

  • Ready for review

@JesseSandberg JesseSandberg linked an issue Dec 5, 2024 that may be closed by this pull request
rename leaflet to leaflet_id #100
Closed
@JesseSandberg JesseSandberg self-assigned this Dec 5, 2024
@JahmalEnnis JahmalEnnis merged commit b092917 into master Dec 6, 2024
@JesseSandberg JesseSandberg deleted the 100-requested-changes-to-attribute-names branch January 8, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JahmalEnnis JahmalEnnis Awaiting requested review from JahmalEnnis

Assignees

@JesseSandberg JesseSandberg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rename leaflet to leaflet_id
2 participants
@JesseSandberg @JahmalEnnis