Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

113 do get counts should analyze all species in species list #114

Conversation

JesseSandberg
Copy link
Contributor

@JesseSandberg JesseSandberg commented Jan 10, 2025

Description

do_get_counts.tcl was set up to take a list of lipid names, but can't actually do anything with that list and raises an error instead. I have fixed it.

Usage Changes

The $spp variable will now be properly iterated through.

Todos

Notable points that this PR has either accomplished or will accomplish.

  • The $spp variable will now be properly iterated through

Review checklist (Reviewer)

  • I understand what the changes are doing and how
  • I understand the motivation for this PR (the PR itself is appropriately documented)

Status

  • Ready for review

@JesseSandberg JesseSandberg linked an issue Jan 10, 2025 that may be closed by this pull request
@JesseSandberg JesseSandberg marked this pull request as ready for review January 10, 2025 21:57
@JahmalEnnis JahmalEnnis merged commit 4a3f16c into master Jan 13, 2025
@JesseSandberg JesseSandberg deleted the 113-do_get_counts-should-analyze-all-species-in-species-list branch January 24, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

do_get_counts should analyze all species in species list
2 participants