Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

22 get cmap is deprecated in matplotlib #90

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

JesseSandberg
Copy link
Contributor

@JesseSandberg JesseSandberg commented Nov 11, 2024

Description

This fixes a Warning from matplotlib and replaces a code block in the notebook with a one-line function call. Plotting.py is now a file that will continue to grow as we add PRs.

Usage Changes

No user-impacting changes (other than the user no longer gets a Warning and the user sees slightly less unecessary code)

Todos

Notable points that this PR has either accomplished or will accomplish.

  • Replaces deprecated matplotlib command with modern one
  • repackages all colormap lines into one function called make_custom_colormap()

Pre-Review checklist (PR maker)

  • Does the figure look the same no matter which cmap you use?
  • New functions are documented
  • Make a testing nb

Review checklist (Reviewer)

  • put the cmap_test notebook in the python directory of DTA, add a lipid and a path, and run the cells.
    cmap_test.zip
  • Do the two heatmap figures look identical?
  • New functions are documented
  • New functions/variables are named appropriately
  • I understand what the changes are doing and how
  • I understand the motivation for this PR (the PR itself is appropriately documented)

Status

  • Ready for review

@JesseSandberg JesseSandberg self-assigned this Nov 11, 2024
@JesseSandberg JesseSandberg linked an issue Nov 11, 2024 that may be closed by this pull request
EzryStIago
EzryStIago previously approved these changes Nov 14, 2024
@EzryStIago EzryStIago dismissed their stale review November 14, 2024 17:39

Not finished review

@EzryStIago EzryStIago merged commit 04c271e into master Nov 14, 2024
@EzryStIago EzryStIago deleted the 22-get_cmap-is-deprecated-in-matplotlib branch November 14, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_cmap is deprecated in matplotlib
2 participants