92 leaflet sorter 3 fails when lipids split across pb #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JesseSandberg
changed the title
gbrannigan
deleted the
92-leaflet-sorting-fails-when-lipids-split-across-pb
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When local_midplane2 is run (leaflet_sorter_3), it has trouble at the borders of the box because it doesn't use pbwithin. Now it does use pbwithin and we no longer get intermittent errors when leaflet sorting.
Usage Changes
None
Todos
Notable points that this PR has either accomplished or will accomplish.
Pre-Review checklist (PR maker)
Review checklist (Reviewer)
Status