Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements two classes: Site (Site.py) and Symmetric_Site (Symmetric_Site.py). It also includes all utility functions necessary (utils.py) and plotting functions necessary (plotting.py) to completely replicate the existing machinery for DTA. It also includes a testing notebook, which will create a symmetric site the old way, a Symmetric_Site the new way, and compare all plots and the resulting delta G. The only thing this won't test is the determination of the accessible area.
Usage Changes
This PR does not change the user experience in any way but adds all the functionality we will need to change the user experience in the future.
Todos
Notable points that this PR has either accomplished or will accomplish.
Pre-Review checklist (PR maker)
Review checklist (Reviewer)
Site_testing.zip
Status