Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site now has a dtheta attribute #97

Conversation

JesseSandberg
Copy link
Contributor

@JesseSandberg JesseSandberg commented Nov 19, 2024

Description

Sites that were only one theta bin wide caused outline_site to fail because dtheta was being determined on the fly by outline_site without sufficient information to determine dtheta in the case that only one theta bin was provided. Now, dtheta is an attribute of the site that gets set by create_simple_site and gets accessed by outline_site.

Usage Changes

None

Todos

Notable points that this PR has either accomplished or will accomplish.

  • Creates dtheta attribute of Site
  • dtheta is set by create_simple_site
  • outline_site now correctly draws single-theta-bin sites

Pre-Review checklist (PR maker)

  • Check to make sure outline_site gives desired results

Review checklist (Reviewer)

  • Checkout branch 95-outline_site-cannot-calculate-dtheta-when-the-site-is-one-bin-wide
  • IMPORTANT!!!! re-install the DTA package (instructions on DTA repo readme)
    single-bin-test.zip
  • Use the testing nb and confirm that outline_site correctly draws one-bin-wide sites
  • I understand what the changes are doing and how
  • I understand the motivation for this PR (the PR itself is appropriately documented)

Status

  • Ready for review

@JahmalEnnis JahmalEnnis merged commit cb8128d into master Dec 4, 2024
@JesseSandberg JesseSandberg deleted the 95-outline_site-cannot-calculate-dtheta-when-the-site-is-one-bin-wide branch January 8, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

outline_site cannot calculate dtheta when the site is one bin wide
2 participants