Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment Question parsing #206

Open
nickjillings opened this issue Apr 24, 2017 · 5 comments
Open

Comment Question parsing #206

nickjillings opened this issue Apr 24, 2017 · 5 comments

Comments

@nickjillings
Copy link
Collaborator

nickjillings commented Apr 24, 2017

No parsing yet for the on-page custom comment-question nodes.

A file structure may follow something like:

saves
|---page
        |---comment1.csv
        |---comment2.csv
        |---comment3.csv

Each csv should have the file-save name followed by the result type for each node. This will allow for multi-entry data types (such as the checkbox and radio) to be contained in the same scope as the single entry (question, number or slider).

nickjillings added a commit that referenced this issue Apr 24, 2017
@BrechtDeMan
Copy link
Owner

Separate from #205?

nickjillings added a commit that referenced this issue Apr 24, 2017
@nickjillings
Copy link
Collaborator Author

Yeah #205 is for the survey but this is for the on-page comments. Maybe they can be wrapped into one...

@BrechtDeMan
Copy link
Owner

Maybe but not necessarily. I was genuinely wondering. Perhaps keeping them apart is simpler.

@nickjillings
Copy link
Collaborator Author

It probably is, that way people can say "I've done these ones" with distinct names instead of names not directly infering what they do: survey_parser.py and commentquestion_parser.py make sense. Maybe the comment-question should be combined with comments though

@BrechtDeMan
Copy link
Owner

Maybe the comment-question should be combined with comments though

Yep this could work. Folder per page containing a file for each fragment comment, and a file for each commentquestion, one line per subject. Should be an incremental change to the commentparser.

@nickjillings nickjillings added this to the v. 1.2.4 milestone Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants