Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sp_DatabaseRestore - support @FileExtensionDiff parameter #3234

Closed
spurdata opened this issue Feb 24, 2023 · 3 comments · Fixed by #3240
Closed

sp_DatabaseRestore - support @FileExtensionDiff parameter #3234

spurdata opened this issue Feb 24, 2023 · 3 comments · Fixed by #3240

Comments

@spurdata
Copy link
Contributor

Is your feature request related to a problem? Please describe.
sp_DatabaseRestore will only restore DIFF backups if they use the *.bak extension. If you use the @FileExtensionDiff = 'dif' or something similar during Ola's backups, the diffs are ignored during restore.

Describe the solution you'd like
I would like sp_DatabaseRestore to support the same @FileExtensionDiff parameter that DatabaseBackup does, so that I do not have to tweak each new version of sp_DatabaseRestore :)

Describe alternatives you've considered
You could also modify the filter "WHERE BackupFile LIKE N'%.bak'" to just include ".dif" if we think that is the most common alternative to ".bak", but this seems like a poor solution.

Are you ready to build the code for the feature?
Yes I have a modified version of 8.13 working.

@BrentOzar
Copy link
Member

Sure, we'd welcome a pull request for that!

@spurdata
Copy link
Contributor Author

spurdata commented Mar 5, 2023

Alrighty, working through that...

BrentOzar added a commit that referenced this issue Apr 15, 2023
…e---support-@FileExtensionDiff

Added @FileExtensionDiff param. Fixes #3234.
@BrentOzar BrentOzar linked a pull request Apr 15, 2023 that will close this issue
@BrentOzar BrentOzar added this to the 2023-05 Release milestone Apr 15, 2023
@BrentOzar
Copy link
Member

Thanks for the pull request! Looks good, works on my machine. Merging into the dev branch, will be in the next release with credit to you in the release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants