Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sp_BlitzLock - add check that session exists #3306

Closed
erikdarlingdata opened this issue Jul 15, 2023 · 0 comments · Fixed by #3308
Closed

sp_BlitzLock - add check that session exists #3306

erikdarlingdata opened this issue Jul 15, 2023 · 0 comments · Fixed by #3308
Assignees
@erikdarlingdata
Labels
enhancement sp_BlitzLock
Milestone
2023-08 Release

Comments

@erikdarlingdata
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I realized that the whole proc will YOLO through everything even if the session name doesn't exist, which sp_HumanEventsBlockViewer does. I thought I had close code parity between the two, but this is missing.

Describe the solution you'd like
Run a check on the XE data to confirm the session name is there

Describe alternatives you've considered
Going to see a Muppets movie

Are you ready to build the code for the feature?
Yes, it's just some copy and paste
@erikdarlingdata erikdarlingdata self-assigned this Jul 15, 2023
erikdarlingdata added a commit to erikdarlingdata/SQL-Server-First-Responder-Kit that referenced this issue Jul 16, 2023
@erikdarlingdata
Adds check for session existence
1ae5fc7 
I should probably add a to-do that also checks to make sure that the event has an xml deadlock report of some variety assigned to it, but Nicht heute, Satan

Closes BrentOzarULTD#3306
@erikdarlingdata erikdarlingdata mentioned this issue Jul 16, 2023
Merged
@BrentOzar BrentOzar added this to the 2023-08 Release milestone Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikdarlingdata erikdarlingdata

Labels
enhancement sp_BlitzLock
Projects
None yet
Milestone
2023-08 Release
Development

Successfully merging a pull request may close this issue.

Issues 3305, 3306, 3307, 3311 erikdarlingdata/SQL-Server-First-Responder-Kit
2 participants
@BrentOzar @erikdarlingdata