Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sp_Blitz] [Enhancement] Inform user that checks are skipped because of permissions #3376

Closed
Montro1981 opened this issue Oct 11, 2023 · 1 comment · Fixed by #3378
Closed

[sp_Blitz] [Enhancement] Inform user that checks are skipped because of permissions #3376

Montro1981 opened this issue Oct 11, 2023 · 1 comment · Fixed by #3378
Assignees
@Montro1981
Labels
sp_Blitz
Milestone
2023-12 Release

Comments

@Montro1981
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We are now checking permissions and skipping checks if the user is not SysAdmin. However, the user is not informed.

Describe the solution you'd like
Include a line in the results telling the user that not all checks may have been executed because the user is not a part of the SysAdmin role.

Describe alternatives you've considered
We could leave it as is.

Are you ready to build the code for the feature?
Will code it and create a PR when completed.
Montro1981 added a commit to Montro1981/SQL-Server-First-Responder-Kit that referenced this issue Oct 11, 2023
@Montro1981
BrentOzarULTD#3376 Added debug and an Informational message
41e3ca9
Montro1981 added a commit to Montro1981/SQL-Server-First-Responder-Kit that referenced this issue Oct 11, 2023
@Montro1981
BrentOzarULTD#3376 Added debug and an Informational message
7198fcb
Montro1981 added a commit to Montro1981/SQL-Server-First-Responder-Kit that referenced this issue Oct 11, 2023
@Montro1981
BrentOzarULTD#3376 Added Informational message about skipping checks
f00c58a
@Montro1981 Montro1981 mentioned this issue Oct 11, 2023
Merged
BrentOzar added a commit that referenced this issue Dec 14, 2023
@BrentOzar
Merge pull request #3378 from Montro1981/SQL-Server-First-Responder-K…
23a8b24 
…it_3376

#3376 Added Informational message about skipping checks
@BrentOzar BrentOzar added this to the 2023-12 Release milestone Dec 14, 2023
@BrentOzar
Copy link
Member

Looks good! Thanks for the pull request. Merging into the dev branch, will be in the next release with credit to you in the release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Montro1981 Montro1981

Labels
sp_Blitz
Projects
None yet
Milestone
2023-12 Release
Development

Successfully merging a pull request may close this issue.

#3376 Added Informational message about skipping checks Montro1981/SQL-Server-First-Responder-Kit
2 participants
@BrentOzar @Montro1981