Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sp_BlitzIndex - Skip missing index details for Modes 1 and 2 #3462

Closed
erikdarlingdata opened this issue Mar 28, 2024 · 2 comments · Fixed by #3465
Closed

sp_BlitzIndex - Skip missing index details for Modes 1 and 2 #3462

erikdarlingdata opened this issue Mar 28, 2024 · 2 comments · Fixed by #3465

Comments

@erikdarlingdata
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Gathering missing index details can be time consuming on some servers (another issue about that to come), but it doesn't make sense to run this part at all in modes that don't do any analysis or return those results.

Describe the solution you'd like
Skip missing index details if using Mode 1 or 2.

Describe alternatives you've considered
Waiting. Endless... waiting.

Are you ready to build the code for the feature?
Sure thing skipperoo.

@erikdarlingdata erikdarlingdata self-assigned this Mar 28, 2024
erikdarlingdata added a commit to erikdarlingdata/SQL-Server-First-Responder-Kit that referenced this issue Mar 29, 2024
@BrentOzar BrentOzar added this to the 2024-05 Release milestone Mar 29, 2024
@BrentOzar
Copy link
Member

I'm glad you did this because I've actually wondered in the past, "Are we gathering the data for every mode, every time?" and not gone into the code to look. Doh!

@erikdarlingdata
Copy link
Contributor Author

@BrentOzar Yeah, looking through all the code, I was surprised at how many checks were completely unrelated. The only one I'm not entirely sure of is ForeignKeys. IndexSanity gets updated using that table, so I left it alone for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants