Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Mode 0 more useful #1751

Merged
merged 2 commits into from
Sep 7, 2018
Merged

Make Mode 0 more useful #1751

merged 2 commits into from
Sep 7, 2018

Conversation

BlitzErik
Copy link
Contributor

Fixes #1739

Fixes # .

Changes proposed in this pull request:

  • Make mode 0 generally more useful to people

How to test this code:

  • Run in @mode = 0, see important stuff that was missing before

Has been tested on (remove any that don't apply):

  • Case-sensitive SQL Server instance
  • SQL Server 2016
  • SQL Server 2017

@BlitzErik BlitzErik added this to the Jazz Gone Bad milestone Sep 7, 2018
@BlitzErik BlitzErik self-assigned this Sep 7, 2018
@BlitzErik
Copy link
Contributor Author

BlitzErik commented Sep 7, 2018 •
edited
Loading

Stuff that changed:

  1. High/Low missing index impact just checks usage, leaves out impact. Impact is frequently a bag of wonk.
  2. Adds borderline dupes to output
  3. Mode 0 will warn about >= 21 indexes on a table, Mode 4 will warn about >= 7
  4. Abnormal psychology is no longer in Mode 0 (xml, spatial, column store, compressed), but retains partitioned/non-aligned partitioned.
  5. Improve computed column function detection
  6. Skips % include, filtered, indexed view warnings

@BlitzErik
Improve CC function detection
15a9afe 
When you add these, no matter how you add them, SQL Server internally adds schema prefixes and quotes things. This change will only find `].[` and not just `.`
BrentOzar
BrentOzar approved these changes Sep 7, 2018
View reviewed changes
Copy link
Member

@BrentOzar BrentOzar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I APPROVE. Good work.

@BlitzErik BlitzErik merged commit c38602e into dev Sep 7, 2018
@BlitzErik BlitzErik deleted the issue_1739 branch September 7, 2018 19:34
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrentOzar BrentOzar BrentOzar approved these changes

@TaraKizer TaraKizer Awaiting requested review from TaraKizer

Assignees

@BlitzErik BlitzErik

Labels
enhancement sp_BlitzIndex
Projects
None yet
Milestone
Jazz Gone Bad
Development

Successfully merging this pull request may close these issues.
2 participants
@BlitzErik @BrentOzar