Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sp_BlitzCache additional plural checks for @SortOrder #1963

Merged
merged 2 commits into from
Feb 15, 2019
Merged

sp_BlitzCache additional plural checks for @SortOrder #1963

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d46a5d3
additional plural checks
RichBenner Feb 13, 2019
33e23d1
removed unnecessary checks
RichBenner Feb 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions sp_BlitzCache.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1026,18 +1026,28 @@ SELECT @MinMemoryPerQuery = CONVERT(INT, c.value) FROM sys.configurations AS c W

SET @SortOrder = LOWER(@SortOrder);
SET @SortOrder = REPLACE(REPLACE(@SortOrder, 'average', 'avg'), '.', '');
SET @SortOrder = REPLACE(@SortOrder, 'executions per minute', 'avg executions');
SET @SortOrder = REPLACE(@SortOrder, 'executions / minute', 'avg executions');
SET @SortOrder = REPLACE(@SortOrder, 'xpm', 'avg executions');
SET @SortOrder = REPLACE(@SortOrder, 'recent compilations', 'compiles');

SET @SortOrder = CASE
WHEN @SortOrder IN ('executions per minute','execution per minute','executions / minute','execution / minute','xpm') THEN 'avg executions'
WHEN @SortOrder IN ('recent compilations','recent compilation','compile') THEN 'compiles'
WHEN @SortOrder IN ('read') THEN 'reads'
WHEN @SortOrder IN ('avg read') THEN 'avg reads'
WHEN @SortOrder IN ('write') THEN 'writes'
WHEN @SortOrder IN ('avg write') THEN 'avg writes'
WHEN @SortOrder IN ('memory grants') THEN 'memory grant'
WHEN @SortOrder IN ('avg memory grants') THEN 'avg memory grant'
WHEN @SortOrder IN ('spill') THEN 'spills'
WHEN @SortOrder IN ('avg spill') THEN 'avg spills'
WHEN @SortOrder IN ('execution') THEN 'executions'
ELSE @SortOrder END

RAISERROR(N'Checking sort order', 0, 1) WITH NOWAIT;
IF @SortOrder NOT IN ('cpu', 'avg cpu', 'reads', 'avg reads', 'writes', 'avg writes',
'duration', 'avg duration', 'executions', 'avg executions',
'compiles', 'memory grant', 'avg memory grant',
'spills', 'avg spills', 'all', 'all avg', 'sp_BlitzIndex')
BEGIN
RAISERROR(N'Invalid sort order chosen, reverting to cpu', 0, 1) WITH NOWAIT;
RAISERROR(N'Invalid sort order chosen, reverting to cpu', 16, 1) WITH NOWAIT;
SET @SortOrder = 'cpu';
END;

Expand Down