Half the recipes in a folder are moved when dragged-and-dropped into another folder #195
Labels
Milestone
Comments
|
It is predictable behavior. You will move n/2 or (n+1)/2 items, depending on if there are an even or odd number of items in the folder you are moving. Subfolders in the folder being moved will make things less predictable. The work around is mildly annoying. Create the target subfolder(s) and move just the recipes into place. I will get a patch together later, but I really need to consider what happens when moving folders with multiple subfolders. |
mikfire
pushed a commit
to mikfire/brewtarget
that referenced
this issue
Feb 20, 2016
Moving folders used childCount() as the test condition in a for loop. Because I moved the children into the new folder, childCount() got decremented by one. This resulted in the loop counter getting incremented, the test condition getting decremented and me moving only about half the children. The fix is a bit more involved, since I don't move folders. I capture the starting childCount at the start and use that for the test condition, and I only take the first non-folder child through the whole operation. The only tricky part is that I don't move folders, so I have to increment a counter to indicate where the first non-folder item is.
|
Should be closed w/ pul request 197 |
rocketman768
changed the title
mikfire
pushed a commit
to mikfire/brewtarget
that referenced
this issue
Feb 21, 2016
The rebase generated way too many collisions. It was faster to create a new branch. Moving folders used childCount() as the test condition in a for loop. Because I moved the children into the new folder, childCount() got decremented by one. This resulted in the loop counter getting incremented, the test condition getting decremented and me moving only about half the children. The fix is a bit more involved, since I don't move folders. I capture the starting childCount at the start and use that for the test condition, and I only take the first non-folder child through the whole operation. The only tricky part is that I don't move folders, so I have to increment a counter to indicate where the first non-folder item is.
|
Closed in #200. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I am experiencing some strange behavior in version 2.3.0.
When a folder containing recipes is dragged inside another folder only some of the recipes in the folder are moved.
At first it appears as though the recipes not moved have disappeared, but after saving and closing Brewtarget the recipes will be in there original location when the software is reopened.
I attached a couple screen shots showing what I am talking about.
The text was updated successfully, but these errors were encountered: