Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fromXML methods are not fault tolerant #239

Closed
mikfire opened this issue Apr 19, 2016 · 1 comment
Closed

fromXML methods are not fault tolerant #239

mikfire opened this issue Apr 19, 2016 · 1 comment

Comments

@mikfire
Copy link
Contributor

mikfire commented Apr 19, 2016

Many other projects are not implementing the beerXML specification properly. In several places, we expect to map directly from a text string to a data type without testing first. When a faulty beerXML export uses "Base Malt" as a fermentable type, we can't map it and promptly dump core.

In every case where we are dependent on mapping XML input to a type, we need to test the map before we simply rely on it working. And yes, I have a fix.
mikfire pushed a commit to mikfire/brewtarget that referenced this issue Apr 19, 2016
Closes issue Brewtarget#239
c6362d2 
I simply make sure we can map from any string to a type. This impacts a few
places, but the code it pretty simple.
mikfire added a commit that referenced this issue Apr 23, 2016
@mikfire
Merge pull request #241 from mikfire/bugs/xmltolerant
ebcf76d 
Closes issue #239 -- fault tolerant fromXML
@mikfire
Copy link
Contributor Author

mikfire commented Apr 23, 2016

merged commit ebcf76d

@mikfire mikfire closed this as completed Apr 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mikfire