Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not export recipe #39

Closed
Mackanzx opened this issue May 14, 2015 · 0 comments
Closed

Can not export recipe #39

Mackanzx opened this issue May 14, 2015 · 0 comments
Assignees
Labels
Milestone

Comments

@Mackanzx
Copy link
Contributor

When exporting recipes, converting the filename QString to ISO-8859-1 seems to break the string, in my environment at least.
"toAscii" of QString was deprecated in QT5, and it is recommended to be replaced with "toLatin1", which was done in commit 6f6315d. In my environment, toLatin1() produces this string:
´┐¢´┐¢´┐¢´┐¢´┐¢´┐¢´┐¢´┐¢´┐¢´┐¢´┐¢´┐¢´┐¢´┐¢´┐¢´┐¢´┐¢´┐¢´┐¢´┐¢´┐¢´┐¢´┐¢´┐¢´┐¢´┐¢´┐¢´┐¢´┐¢´┐¢´┐¢´┐¢´┐¢´┐¢´┐¢´┐¢´┐¢┐¢´┐¢´┐¢´┐¢´┐¢´┐¢´┐¢i s0@´┐¢T∟´┐¢´┐¢

I propose to not convert the QString to anything, since setFileName of QFile takes a QString.

Pull request: #40

Mackanzx added a commit to Mackanzx/brewtarget that referenced this issue May 14, 2015
…ting the QString filename before feeding it to a QFile.
@rocketman768 rocketman768 added this to the v2.2.0 milestone May 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants