Water Chemistry: Crash when selecting added salt name or amount

[OWoolland]

Hello, I've been having a play with the water chemistry tool that has been added. It's looking really cool and really promising, thank you for the work on it.

I'm having trouble using the interface, receiving:

munmap_chunk(): invalid pointer

when selecting a salt name or amount on the Water Chemistry tool. I have attached a full backtrace gdb.txt

I attempted to chase the error out but not being super familiar with Brewtarget's source code, QT or more complex databases I may have been barking up the wrong tree. I got as far as finding that disabling this line allowed the water calculator to proceed as I hoped but presumably wasn't a good idea for the software as a whole!

Having a look around in the database generated during compilation I notice that (for me) the Salt table appears to be empty.

Could this be related?

All the best and keep up the good work!

FWIW I am mostly clean building in a Docker container to try to keep things sane.

[matty0ung]

Hi, Thanks for the detailed bug report and diagnostics. I'll have a look and see if I can workout what's going on.

[matty0ung]

OK, good news is I can reproduce the bug and I know why it's happening. I need to think about the right fix, which might not be entirely trivial, but I have a couple of ideas...

[OWoolland]

That's great! Good luck and thank you for taking a look 🙂

[matty0ung]

I have uploaded a fix that works-on-my-machine™ to #684. We'll include it in the 3.0.4 release.

As ever, please don't hesitate to let us know if you hit other problems.

[OWoolland]

First impressions for me are that the fix works really nicely! Thanks again for looking in to it - amazingly quick response and fix!

From my perspective I am happy for the issue to close whenever it is appropriate.

All the best :)

[matty0ung]

Closing now that release 3.0.4 is out.