-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tabs on Editor Windows not displaying correctly on macOS #787
Comments
Sorry to hear you're having problems. Thanks for the screen shots. Can you confirm what version of Brewtarget you're running? Also, could you have a look and see if there are any ERROR or WARNING lines in the log file? (If you go to Tools > Options > Logging, it should show you the log file directory, and in there should be a file called brewtarget.log.) |
Version 3.0.10 I can see no errors reported in the log at all. This is the Normal logging from starting the app and immediately opening the Equipment Editor (which shows as in the macOS screen capture above):
Also here's the full Debug log for the same steps: |
Thanks - that's helpful in ruling quite a few things out! Do you get the same problem on other editors (eg Hop Editor or Yeast Editor)? |
Yes, it's the same on all the editors; Equipment was just an example. |
Ah, OK, that's useful. I think this is an issue with the Qt framework somehow deciding that the text is too long to display, and so showing "..." instead. Other people report seemingly similar issues on Mac (eg https://stackoverflow.com/questions/72828926/qtablewidgetitem-displays-three-dots-instead-of-full-text and https://forum.qt.io/topic/119371/text-in-qtabbar-on-macos-is-truncated-or-elided-by-default-although-there-is-empty-space). It may well be some small setting on QTabWidget (eg https://doc.qt.io/qt-5/qtabwidget.html#elideMode-prop) that doesn't matter on Windows / Linux but is important to specify on Mac. I'll have a look to see if I can find something obvious to try, but I don't have a Mac to try things out on, so it may be a question of offering you some patched builds to try... |
I'm happy to be an unofficial tester. |
I did try to build brewtarget myself on my mac to see if I could help but I get errors at linking stage:
It's related to xalan-c which is disabled in the Homebrew repository so I installed xalanc from MacPorts instead. Maybe this is the problem. I was able to build successfully on my Ubuntu machine (following more or less the same process):
Unfortunately I'm not skilled enough to diagnose what's wrong with the mac build but if I could get it working I could try out some changes very quickly. |
I feel your pain on Mac builds! But there is help at hand. You actually just need to follow what's done in the automated builds (see https://github.com/Brewtarget/brewtarget/blob/develop/.github/workflows/mac.yml). For the reasons you say, you need to have both MacPorts and Homebrew installed. With that starting point, if you then install Python (eg At that point you should then be able to do either a CMake build (in the |
Cool! That's already progress! Have a play around with https://github.com/Brewtarget/brewtarget/blob/develop/ui/equipmentEditor.ui Sometimes removing things like |
Sounds like you've tried a lot of the things I would have! A couple of further ideas:
|
That's good progress! What happens on the altered Priming Dialog if you change the |
That's encouraging - and interesting to see the text orientation on those side tabs. Maybe MacOS doesn't like us trying to force side tab text to be horizontal? At this point, I'd be tempted to start copying tabs and input fields over from, say Equipment Editor to Priming Dialog. Obviously the fields will be empty/unconnected, but I'm thinking if we could gradually turn Priming Dialog into Equipment Editor from a layout perspective (probably keeping an extra tab for the real fields of Priming Dialog so nothing breaks!) then we'd hopefully find the point at which things break. |
Yes, good idea. In the |
Excellent! Next step is probably to have a proper look at |
After a bit of digging, I think I now understand what |
OK, so I've done a minimalistic fix. I didn't totally get to the bottom of why the tabs get drawn too small on Mac when we "unrotate" them back to horizontal via the Also added some special case handling so that the rotated side tabs that do work on Mac (the icons) still work! |
Thanks @matty0ung. I've built the latest from master on macOS and I can confirm the tabs look good now (still good on Ubuntu too). Do you want me to close this issue now? |
Excellent - many thanks. Leave the issue open just for a short while longer. I'll close it when I do the 3.0.11 release (hopefully today!). |
Release went smoothly for once! 😄 Fix included in https://github.com/Brewtarget/brewtarget/releases/tag/v3.0.11. |
The Tabs on the Editor windows (Equipment, Fermentables, Hops, etc.) are not displaying correctly on macOS. They show correctly on Ubuntu.
For example, this is how the Equipment Editor windows hows on Ubuntu 22.02 and macOS Sonoma 14.2.1.
BTW I've just started using Brewtarget and I'm loving it. Thanks to everyone involved!
The text was updated successfully, but these errors were encountered: