Fix for incorrect BrewNote calculation, plus small tidy-up of BtHorizontalTabs #790
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #789 is correcting the following line of
src/model/BrewNote.cpp
:double BrewNote::projVolIntoBK_l() const { return m_projVolIntoFerm_l; }
to:
double BrewNote::projVolIntoBK_l() const { return m_projVolIntoBK_l; }
The other changes are tidying up
BtHorizontalTabs
(specifically pulling code out of the header file into a .cpp file and adding some comments). This doesn't change functionality but is part of investigating #787.