Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra define needed for pi constant for RadarChart on Windows #539

Merged
merged 1 commit into from
Apr 5, 2021

Conversation

matty0ung
Copy link
Contributor

Fix for #538

I don't have a Windows build set up on my machine, so it would be great if someone who has could quickly check this compiles as expected.

@Lubart
Copy link

Lubart commented Apr 13, 2023

Compiling on Windows 10 under Visual Studio 2022 still getting error. Please see below.
C++ Language Standard used: ISO C++17 Standard (/std:c++17).
3>RadarChart.cpp
3>D:\Git\brewtarget\src\RadarChart.cpp(50,40): error C2065: 'M_PI': undeclared identifier
3>D:\Git\brewtarget\src\RadarChart.cpp(50,17): error C2737: '`anonymous-namespace'::RadiansInACircle': const object must be initialized

@matty0ung
Copy link
Contributor Author

Ah, interesting. I think there is a straightforward fix now we're on C++20. Will have a look soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants