Fixes #701 drag and drop is broken #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The login in BtTreeView::mimeData was broken. As we always set itsa, the std::optional variable would have never been false. This resulted in setting the mime type to `application/x-brewtarget-folder` for anything that wasn't a Recipe, Style or Folder. Since the tables are configured to only accept `application/x-brewtarget-ingredient`, they wouldn't accept the drop. To fix it, I changed all the tests around. We test for Recipe, Style and Equipment; then we test for Folder; then we test to not be Water. That sets all of the mime types correct. I also added an `application/x-brewtarget-water` in case I ever want to get clever.
matty0ung
approved these changes
Dec 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic in BtTreeView::mimeData was broken. As we always set itsa, the std::optional variable would have never been false. This resulted in setting the mime type to
application/x-brewtarget-folderfor anything that wasn't a Recipe, Style or Folder. Since the tables are configured to only acceptapplication/x-brewtarget-ingredient, they wouldn't accept the drop.To fix it, I changed all the tests around. We test for Recipe, Style and Equipment; then we test for Folder; then we test to not be Water. That sets all of the mime types correct. I also added an
application/x-brewtarget-waterin case I ever want to get clever.