Fix for crash when editing fermentation ages #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #785
The fermentation age fields are handled a bit differently than most other ones. Although they are a measure of time (duration), we actually treat them as raw numbers because we're only measuring to the nearest day, and don't want to start offering to show things in hours/minutes/seconds etc. The bug was we were saying "convert this field to its standard units of measurement" when we should have been saying "get this field as a raw number".
EDIT: Fighting a bit to get the Windows build working. Turns out some of the 32-bit MSYS2 packages/groups we were relying on previously are no longer available. (Works on my local machine because they are already installed, but not on GitHub Actions because there you install from scratch each time.) Will have a look at whether we can get 64-bit Windows build working.