Fixes bugs with brewday step numbering (and database version update) #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thank you. |
|
Can you cherry-pick and repush this against brewtarget/master? |
|
@Brewtarget/developers this is a heads-up that the database schema is about to change. |
|
For sure! I'll try to do it Friday or during the weekend. |
|
Will merge this immediately on a rebase to the master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taken from here:
Also, when adding or taking out steps the step numbers do not change correctly; for example I'll end up with two "step 4's" and no step 5.
It took me some time (had no idea there was a trigger), but I found the bug and fixed it.
Furthermore, found (and fixed) another bug when updating the database version number.