Skip to content

Commit

Permalink
Local testing docker links (facebook#2662)
Browse files Browse the repository at this point in the history
* Fix a command style in docs

* Add a link to docker's docs
  • Loading branch information
EnoahNetzach authored and morgs32 committed Sep 1, 2017
1 parent 4519479 commit 47efa79
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ and then run `npm start` or `npm run build`.

## Contributing to E2E (end to end) tests

**TL;DR** use the command yarn e2e:docker to run unit and e2e tests.
**TL;DR** use the command `yarn e2e:docker` to run unit and e2e tests.

More detailed information are in the dedicated [README](/packages/react-scripts/fixtures/kitchensink/README.md).

Expand Down
2 changes: 2 additions & 0 deletions packages/react-scripts/fixtures/kitchensink/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ In order to run them locally, without having to manually install and configure e
This is a simple script that runs a **Docker** container, where the node version, git branch to clone, test suite, and whether to run it with `yarn` or `npm` can be chosen.
Simply run `yarn e2e:docker -- --help` to get additional info.

If you need guidance installing **Docker**, you should follow their [official docs](https://docs.docker.com/engine/installation/).

## Writing tests

Each time a new feature is added, it is advised to add at least one test covering it.
Expand Down

0 comments on commit 47efa79

Please sign in to comment.