Skip to content

Commit

Permalink
tools: treat SIGABRT as crash
Browse files Browse the repository at this point in the history
Otherwise, potentially no output is shown for aborts.

PR-URL: nodejs#19990
Refs: nodejs#19903
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
  • Loading branch information
addaleax authored and BridgeAR committed May 1, 2018
1 parent 0e40b1d commit ae3f3d7
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions tools/test.py
Original file line number Diff line number Diff line change
Expand Up @@ -582,8 +582,7 @@ def HasCrashed(self):
# Timed out tests will have exit_code -signal.SIGTERM.
if self.output.timed_out:
return False
return self.output.exit_code < 0 and \
self.output.exit_code != -signal.SIGABRT
return self.output.exit_code < 0

def HasTimedOut(self):
return self.output.timed_out;
Expand Down

0 comments on commit ae3f3d7

Please sign in to comment.