Skip to content

Commit

Permalink
test: fix argument order in assertions
Browse files Browse the repository at this point in the history
PR-URL: nodejs#23589
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
  • Loading branch information
Illescas, Ricardo authored and BridgeAR committed Oct 15, 2018
1 parent 6e017f9 commit db70175
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions test/parallel/test-child-process-ipc.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,13 @@ child.stdout.on('data', function(data) {
console.log(`child said: ${JSON.stringify(data)}`);
if (!gotHelloWorld) {
console.error('testing for hello world');
assert.strictEqual('hello world\r\n', data);
assert.strictEqual(data, 'hello world\r\n');
gotHelloWorld = true;
console.error('writing echo me');
child.stdin.write('echo me\r\n');
} else {
console.error('testing for echo me');
assert.strictEqual('echo me\r\n', data);
assert.strictEqual(data, 'echo me\r\n');
gotEcho = true;
child.stdin.end();
}
Expand Down
2 changes: 1 addition & 1 deletion test/pummel/test-net-timeout.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ echo_server.listen(common.PORT, function() {
});

client.on('data', function(chunk) {
assert.strictEqual('hello\r\n', chunk);
assert.strictEqual(chunk, 'hello\r\n');
if (exchanges++ < 5) {
setTimeout(function() {
console.log('client write "hello"');
Expand Down

0 comments on commit db70175

Please sign in to comment.