-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offline capability (videos, audio, news, etc.) when connection lacks #155
Comments
So you mean: downloading a video for a future watching or caching the whole video while watching it in case of an internet connection error? |
"Caching the whole video while watching" always, even if connection is excellent. This idea is taken from another app, called ViMusic (fdroid). It put aside (for future offline use) all that I listen, even mistakenly. Do you want delete an already downloaded music track? Go to "download" tab and delete what you want. To do this please add a download "folder" limit, for example max 5 gb or max 3 months, or a combination of both, in order to not consume excessive resources. News download all. They are few megabytes (pictures and audio included). |
What you mean is even another feature, that we can calling "favorites" section or "archive" section. An user can going on a video and then push "send to archive" or "add to favorites". |
That should be doable. I limited the cache to ~30 seconds because the player can lag (crash?) on devices without a lot of RAM.
I agree for the music player, but is it really useful for a video player? For example, you can listen to a music several times, but I don't guess that you would watch the same video more than 3 to 4 different times (and offline).
That's seems a good idea, I will see how I can implement it (images and text first).
Yes, that was the idea; I will open different issues to track the progress of the features' implementation. |
I have a Senna docufilm put aside. Eh eh eh. Okay dev, you are the best. I put my wishes in your hands. |
My approach is different: in my idea I haven't to think about anything. Download just happen automatically. In your approach you have to push physically the "download" button, and what if the connection lack when you return to see that video again? Maybe you travel in a train that day... but you forgot to push "download"... |
Or maybe both the ideas "automatically" (caching) and "watch later". |
We can adding an on/off caching switch (for less gifted devices). |
Yes: you download a video for a future use, but you need to tap on the download button. Then you can watch it later.
I think I will add a setting to manually set the cache time, so you would be able to set it to 1 hour. The point that I want to understand is whether the video should still be available, even after closing the player or the app. My point is that with your approach, all the videos you have seen will be saved on your device, but you may only watch a few of them again. For example, when you see a post-race interview of a particular driver, you will not watch it a lot of time. However, race highlights may be saved. That's why a non-automatic approach seems the best to me. |
My solution to get the best of two worlds (automatic and based on push) is setting a double trap: • all those videos automatically downloaded are subject to two rules simultaneously:
Then Box box automatically delete when they expire or they reach the volume limit. Do you want store "forever" a particular video? Send to archive (manually). • Based on manual push: manual download is subject on same above rules or send (it directly) to archive to store the video permanently. |
Ok, that's seems to be the best solution. I will add different settings to that. |
Okay dev, my philosophy (thinking) is ended. Now it begins the code time. And afterwards we can celebrate the result. 🤓 |
Changed logic in "manual push". Tell me if you approve. Read my edited message above. In this way the download (manual or automatic) always has the same behavior. Same for the "send to archive" function (basically it says to the app "avoid the download rules" and store the media content permanently). Basically "send to archive" becomes something like "sanctify this video". Make it immortal. 🤣 |
So I have been working on this for some days now in #163. I think that the current implementation is the best for a newsreader/video player. |
Excellent! |
You are a kind man. This is a great work! |
So I just merged the PR! |
You have to be logged in to be able to download the file.
Here I am wrong because it is more a prereleae than a debug version. Anyway, the debug version is a version of the app which logs everything while active, so it is very useful to find bugs, add new features... but not made for production/public releases. |
Use case: the internet connection lacks for any reason (airplane mode included).
Box, box automatically downloads only the heavy data (for example videos) that I effectively seen: news data are always got because they are light.
Optionally you could adding an on/off switch in settings for this feature.
The text was updated successfully, but these errors were encountered: