Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sync converstion for ImplicitObjectCreationSyntax #952

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

j3parker
Copy link
Member

@j3parker j3parker commented Aug 1, 2024

No description provided.

@j3parker j3parker requested a review from omsmith as a code owner August 1, 2024 19:28
@@ -272,6 +272,10 @@ private ExpressionSyntax Transform( ExpressionSyntax expr )
IdentifierNameSyntax identExpr => identExpr
.WithIdentifier( RemoveAsyncSuffix( identExpr.Identifier, optional: true ) ),

ImplicitObjectCreationExpressionSyntax implicitObjectCreationExpr => implicitObjectCreationExpr
.WithArgumentList( Transform( implicitObjectCreationExpr.ArgumentList ) )
.WithInitializer( MaybeTransform( implicitObjectCreationExpr.Initializer, Transform ) ),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same as ObjectCreationSyntax except that ArgumentList is not nullable for ImplicitObjectCreationExpressionSyntax, so we don't need the MaybeTransform wrapper.

@j3parker j3parker merged commit 82dda81 into main Aug 1, 2024
1 check passed
@j3parker j3parker deleted the sync-implicit-object-creation branch August 1, 2024 19:31
j3parker added a commit to Brightspace/D2L.Security.OAuth2 that referenced this pull request Aug 1, 2024
j3parker added a commit to Brightspace/D2L.Security.OAuth2 that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants