Skip to content

Commit

Permalink
Merge pull request #32 from Brightspace/s-akulick/no-console-web-refa…
Browse files Browse the repository at this point in the history
…ctor

Refactored web configs and added no-console rule
  • Loading branch information
Scy-D2L authored May 7, 2020
2 parents 08b8262 + a6f05d1 commit c26eddc
Show file tree
Hide file tree
Showing 5 changed files with 26 additions and 47 deletions.
23 changes: 19 additions & 4 deletions browser-config.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,21 @@
const { sortMemberRules } = require('./sort-member-config');

module.exports = {
"extends": "./index.js",
"env": {
"browser": true
}
"extends": "./index.js",
"parser": "babel-eslint",
"env": {
"browser": true
},
"plugins": [
"html",
"sort-class-members"
],
"globals": {
"D2L": false,
"Promise": false
},
"rules": {
"no-console": ["error", { "allow": ["warn", "error"] }],
...sortMemberRules
}
};
17 changes: 3 additions & 14 deletions lit-config.js
Original file line number Diff line number Diff line change
@@ -1,21 +1,11 @@
const { sortMemberRules } = require('./sort-member-config');

module.exports = {
"extends": "./index.js",
"parser": "babel-eslint",
"extends": "./browser-config.js",
"env": {
"browser": true,
"es6": true
},
"plugins": [
"lit",
"html",
"sort-class-members"
"lit"
],
"globals": {
"D2L": false,
"Promise": false
},
"rules": {
"arrow-spacing": 2,
"no-confusing-arrow": 2,
Expand All @@ -41,7 +31,6 @@ module.exports = {
"lit/no-template-bind": 2,
"lit/no-template-map": 0,
"lit/no-useless-template-literals": 2,
"lit/no-value-attribute": 2,
...sortMemberRules
"lit/no-value-attribute": 2
}
};
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "eslint-config-brightspace",
"version": "0.6.7",
"version": "0.7.0",
"description": "Common Brightspace eslint configs.",
"main": "index.js",
"scripts": {
Expand Down
19 changes: 2 additions & 17 deletions polymer-3-config.js
Original file line number Diff line number Diff line change
@@ -1,21 +1,6 @@
const { sortMemberRules } = require('./sort-member-config');

module.exports = {
"extends": "./index.js",
"parser": "babel-eslint",
"env": {
"browser": true
},
"plugins": [
"html",
"sort-class-members"
],
"globals": {
"D2L": false,
"Polymer": false
},
"extends": "./browser-config.js",
"rules": {
"strict": 0,
...sortMemberRules
"strict": 0
}
};
12 changes: 1 addition & 11 deletions polymer-config.js
Original file line number Diff line number Diff line change
@@ -1,15 +1,5 @@
module.exports = {
"extends": "./index.js",
"env": {
"browser": true
},
"plugins": [
"html"
],
"globals": {
"D2L": false,
"Polymer": false
},
"extends": "./browser-config.js",
"rules": {
"strict": 0
}
Expand Down

0 comments on commit c26eddc

Please sign in to comment.