Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GAUD-7145] tab-panel > add labelledBy support #5253

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

KearseTrevor
Copy link
Contributor

@KearseTrevor KearseTrevor commented Dec 18, 2024

https://desire2learn.atlassian.net/browse/GAUD-7145

  • added labelledBy and sprouting aria-labelledBy from the prop as referenced in the ticket

@dbatiste , when it comes to the last point

Review updated . Some consumers are relying on d2l-tab-panel-selected so we probably need to keep this event. However, hopefully we only need to dispatch d2l-tab-panel-text-changed if text is provided, and we no longer need to dispatch that event with the new API.

We can't prune that part of the code until the new version is fully in place - just call out of scope for this story?

@KearseTrevor KearseTrevor requested a review from a team as a code owner December 18, 2024 21:14
Copy link
Contributor

Thanks for the PR! 🎉

We've deployed an automatic preview for this PR - you can see your changes here:

URL https://live.d2l.dev/prs/BrightspaceUI/core/pr-5253/

Note

The build needs to finish before your changes are deployed.
Changes to the PR will automatically update the instance.

Copy link
Contributor

@dbatiste dbatiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just consider changing the documentation comment. Otherwise looks good.

@KearseTrevor KearseTrevor merged commit f1338ef into main Dec 20, 2024
6 checks passed
@KearseTrevor KearseTrevor deleted the GAUD-7145/panel-support-labelledBy branch December 20, 2024 15:55
Copy link

🎉 This PR is included in version 3.76.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants