fix: Incorrect operator precedence in conditional assembly expressions #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavek-kucera
requested review from
jirimosinger
and removed request for
jirimosinger
jirimosinger
approved these changes
May 2, 2022
Comment on lines
+304
to
+310
| auto o = get_operator(symbol); | ||
| if (o == ca_expr_ops::UNKNOWN) | ||
| return std::monostate(); | ||
| bool unary = is_unary(o); | ||
| bool binary = is_binary(o); | ||
| if (!unary && !binary) | ||
| return invalid_by_policy(); |
There was a problem hiding this comment.
Do you want to create a static function in ca_common_expr_policy that will do this set of checks as this part is duplicated 3 times?
There was a problem hiding this comment.
the is_unary and is_binary are specialized by the individual policies, so I cannot really do it that way, but I am considering just droping all those functions in favor of one switch(-like) code...
There was a problem hiding this comment.
Ok, I see. Other option could be having a base class (e.g. ca_arithmetic_policy_base) from which the other policies could be derived.
jirimosinger
approved these changes
May 2, 2022
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eclipse-che4z#259