Add missing typescript type definitions #689
Conversation
| * For PDF canvases, adds another page. If width and/or height are omitted, | ||
| * the canvas's initial size is used. | ||
| */ | ||
| addPage(width?: number, height?: number): void |
There was a problem hiding this comment.
PDF is not supported in this library though 🤔
There was a problem hiding this comment.
Apologies I should have clarified this.
The following types were directly copied from skia-canvas which this project depends on:
GlobalCompositeOperation
CanvasLineCap
CanvasLineJoin
CanvasTextBaseline
CanvasTextAlign
TextMetrics
CanvasFillRule
CanvasRenderingContext2D
CanvasGradient
CanvasPattern
It is correct to be bringing in these types, but as you rightfully point out, this library does not currently implement all features. I was reluctant to start removing type properties / class methods as I'm uncertain which are, and are not, implemented. I'm hoping someone with more experience (i.e. the maintainers) can help out here.
The only modifications I've made are to CanvasRenderingContext2D:
- To add method
setTransform(a: number, b: number, c: number, d: number, e: number, f: number): voidin addition to the existingsetTransform(transform?: DOMMatrix2D): void - To modify
fill(fillRule?: CanvasFillRule): voidtofill(path?: Path2D, fillRule?: CanvasFillRule): void
These changes now allow my project to build (tsc) where before it was failing (as described in #659).
This PR closes issue #659