fixed bot spamming, updated /register and /stat #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…name from properties. Improved /register.
VsevladHort
approved these changes
Feb 9, 2024
lez-doit
reviewed
Feb 12, 2024
| user.setUserId(userId); | ||
| user.setGuildId(guildId); | ||
| user.setDateRegistration(LocalDate.now()); | ||
| return user; |
There was a problem hiding this comment.
Shouldn't we save the created user into db in such case?
There was a problem hiding this comment.
User is saved a bit later, when he passes the registration and submits his GitHub username. But if it is more convenient, I can add that line here
There was a problem hiding this comment.
If we save the data later, it's alright. However, I suppose it would be better to use getUser method only for getting some actual users from DB, and extract the logic of their creation somewhere else.
Kiriche
approved these changes
Feb 12, 2024
lez-doit
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bot used to answer EVERY message it received in guild. Now this logic is deleted.
/stat used "admin" role to check if user has privilege to use the command. Now the role name is specified in .properties, so StatCommand uses the property, and not a hardcoded string.
/register could be used only if we had stored user in DB. Now, if user's entity is missing, it will be automatically created when he passes the registration. (By default, it is still created when user joins a guild).