fix: buffer-alloc pads a buffer by repeating

[aviadatsnyk]

There seems to be a bug in the code. Since buffer-alloc is not padding with zeros, but rather duplicates the string it was given. For example the string "a" will be deemed equal to the string "aaaaaa".

> require('safe-compare')('a', 'aaaaaaaaaaaa')
true

This pr mitigates this by right-padding the buffer with zeros.

[coveralls]

Coverage remained the same at 100.0% when pulling 9f51dd9 on aviadatsnyk:master into b29bad3 on Bruce17:master.

[coveralls]

Coverage remained the same at 100.0% when pulling 3c62de2 on aviadatsnyk:master into b29bad3 on Bruce17:master.

[coveralls]

Coverage remained the same at 100.0% when pulling 3c62de2 on aviadatsnyk:master into b29bad3 on Bruce17:master.

[Bruce17]

This is interesting: I cannot reproduce your error.

Which package and Node.js version are you using?

[aviadatsnyk]

safe-compare@1.1.1
node@6.11.5 and node@8.9.3

[Bruce17]

@aviadatsnyk now I can reproduce it (actually I had a problem with nvm, my fault).

Please change your code to:

var bufA = bufferAlloc(len, 0, 'utf8');
bufA.write(strA);
var bufB = bufferAlloc(len, 0, 'utf8');
bufB.write(strB);

[aviadatsnyk]

@Bruce17 done.