Skip to content

Commit

Permalink
[release/5.0] Fix GC hole with STOREIND of LCL_VAR_ADDR/LCL_FLD_ADDR
Browse files Browse the repository at this point in the history
Backport of (part of) dotnet#45818 to release/5.0

Fixes: dotnet#45557

Reported by Roslyn. Bad GC info can lead to an unexplained crash that can't easily be found or worked around.

Manual, new unit test, CLR outerloop, SuperPMI asm diffs.

Low
  • Loading branch information
BruceForstall committed Dec 11, 2020
1 parent 5d131e0 commit c230981
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/coreclr/src/jit/emitxarch.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3113,7 +3113,7 @@ void emitter::emitInsStoreInd(instruction ins, emitAttr attr, GenTreeStoreInd* m
}

// Updating variable liveness after instruction was emitted
codeGen->genUpdateLife(varNode);
codeGen->genUpdateLife(mem);
return;
}

Expand Down

0 comments on commit c230981

Please sign in to comment.