Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added coordinate copy with from laser point #1

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

suryabhaiin
Copy link

Added coordinate copy with from laser point and also create polyzone at specific coordinate pointed by laser
No any overlap and conflic with existing functions

Any Vector copy like vector3, vector3, heading and cords in json format
Any Coordinate copy like vector3, vector3, heading and only coordinate and coordinate in json format

Commands restricted for admin
Create Zone At pointed cooardinate
Create Zone At point
createzone at laser point coordinate
Spell correction
@BryceRussell
Copy link
Owner

Thanks for the PR! I took a look at the new /plaser command in-game, and it looks really nice! What do you think about combining the improvements made in /plaser like the laser, controls, etc with the /polygun command? I think it would be nice if this was an all-in-one command that allowed you to do everything instead of having two different commands.

Error fix
Laser and Polygun command merged
Laser and Polygun command merged
and one minor bug fix
@suryabhaiin
Copy link
Author

Thanks for the PR! I took a look at the new /plaser command in-game, and it looks really nice! What do you think about combining the improvements made in /plaser like the laser, controls, etc with the /polygun command? I think it would be nice if this was an all-in-one command that allowed you to do everything instead of having two different commands.

Done brother.

@BryceRussell
Copy link
Owner

BryceRussell commented Mar 18, 2024

@suryabhaiin I tried this out in game, and it is acting buggy and not working correctly

  • The new laser is showing when not aiming
  • The new laser disappears after aiming and the old laser is shown instead
  • Entity zones are created after aiming instead of updating in real time as you aim around
  • When attempting to create a zone using G it errors saying "There is no close vehicle"

Do you think you can fix these issues?

@suryabhaiin
Copy link
Author

@suryabhaiin I tried this out in game, and it is acting buggy and not working correctly

  • The new laser is showing when not aiming
  • The new laser disappears after aiming and the old laser is shown instead
  • Entity zones are created after aiming instead of updating in real time as you aim around
  • When attempting to create a zone using G it errors saying "There is no close vehicle"

Do you think you can fix these issues?

New laser added for free aim, thats why its show without aiming.
New laser hide after aiming becouse i keep your work as it is. my work only enabled when not aiming.
On point number 3 i will check and reconfirm soon
Its due to may be your G key mapped with any other script for some vehicle related task. so if this is an issue then i will chenge key.

for avoiding any issue on your old work that why i created 2nd command first.

@BryceRussell
Copy link
Owner

BryceRussell commented Mar 19, 2024

I think it would be better if these were combined into one instead of being somewhat separate. For example:

  • Having the laser exist only while aiming
  • Replacing old laser style with new laser style
  • Allowing the new control schema to control everything while also including the old control for scaling the zone size

If you want, it may be easier if you PR these as smaller changes. For example, you could create a PR to update only the laser, and another PR to update the control system.

aim to add zone issue fix
laser issue fix
@suryabhaiin
Copy link
Author

suryabhaiin commented Mar 19, 2024

I think it would be better if these were combined into one instead of being somewhat separate. For example:

  • Having the laser exist only while aiming
  • Replacing old laser style with new laser style
  • Allowing the new control schema to control everything while also including the old control for scaling the zone size

If you want, it may be easier if you PR these as smaller changes. For example, you could create a PR to update only the laser, and another PR to update the control system.

Check last commit. i think this is what you want.
and you want to display laser only when aimng but the main purpose of putting laser alway on when command enable to copy that coordinate where laser is point. i dont want to aim every time to point laser. that why i keep laser alway on.

@BryceRussell
Copy link
Owner

Ok, I will let you know what I think next time I get a chance to pull the changes down and try it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants