Prototype of Vortex -> Sardine #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am correcting some drifting issues on the tidal_loop side.
I don't really know how to convert the timestamp latency compensation. It's probably better to remove that faulty code so that I can start fresh thinking about how to make the proper timestamp!
Looks like the round() operation was causing some imprecisions in the SuperDirt messages being sent.
The Vortex timestamp is quite obviously not right. Thought experiment: what if we let Sardine decide of it's own timestamp? All the other SuperDirt events are going through this timestamping method anyway.
- Removed the subscription methods from the clock, moved to the bowl. - Some clever maths to get rid of the dependance on link_clock for timing/cycle calculation. This should now be working for both clocks. Some issues remain: vortex is way too fast. Will see what I can do about that
There is still something to fix with the rate the vortex patterns are being played at. I have tried tweaking some numbers with very moderate success. For now, the tracks d1..d9 are automatically getting a .slow(4) applied to them.
The faster we go, the better the precision?
I started documenting TidalVortex on the website
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.