Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rely on llm status rather than initialised variable #15117

Merged
merged 5 commits into from
Dec 4, 2024
Merged

rely on llm status rather than initialised variable #15117

merged 5 commits into from
Dec 4, 2024

Conversation

shogunpurple
Copy link
Member

Description

Update LLM code to use the llm attribute on the LargeLanguageModel wrapper, rather than an initialised variable that wasn't needed

@shogunpurple shogunpurple requested a review from a team as a code owner December 4, 2024 10:16
@shogunpurple shogunpurple requested review from samwho and removed request for a team December 4, 2024 10:16
@qa-wolf QA Wolf
Copy link

qa-wolf bot commented Dec 4, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@github-actions github-actions bot added size/s and removed size/xs labels Dec 4, 2024
@shogunpurple shogunpurple merged commit 963d162 into master Dec 4, 2024
19 checks passed
@shogunpurple shogunpurple deleted the openai-fix branch December 4, 2024 11:08
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samwho samwho samwho approved these changes

Assignees
No one assigned
Labels
size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shogunpurple @samwho