Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix string-templates on dev #15159

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Fix string-templates on dev #15159

merged 1 commit into from
Dec 11, 2024

Conversation

adrinr
Copy link
Collaborator

@adrinr adrinr commented Dec 11, 2024

Description

Fixing the following error on dev after recent rollup updates on #15151.
image

Copy link

qa-wolf bot commented Dec 11, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@github-actions github-actions bot added firestorm Data/Infra/Revenue Team size/xs labels Dec 11, 2024
Copy link
Member

@aptkingston aptkingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aptkingston aptkingston merged commit 80b8d1c into master Dec 11, 2024
19 checks passed
@aptkingston aptkingston deleted the fix-dev-stringtemplates branch December 11, 2024 11:10
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firestorm Data/Infra/Revenue Team size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants