Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read headers in batch on getRows() #1

Merged
merged 2 commits into from
May 16, 2024
Merged

Read headers in batch on getRows() #1

merged 2 commits into from
May 16, 2024

Conversation

adrinr
Copy link
Collaborator

@adrinr adrinr commented May 16, 2024

The current flow, when running getRows, checks if the headers are loaded. If they are not, we first load the headers and then we run the get. These 2 calls are slow, and they can be speed up using the batchGet endpoint provided by google

@adrinr adrinr requested a review from mike12345567 May 16, 2024 08:09
Copy link

@mike12345567 mike12345567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - very nice find!

@adrinr adrinr merged commit 135d01e into main May 16, 2024
@adrinr adrinr deleted the read-headers-in-batch branch May 16, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants