-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/more chains #109
Feat/more chains #109
Conversation
…r chains in networks.ts
@portdeveloper is attempting to deploy a commit to the BuidlGuidl Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tysm Port! This is great! and everything works nicely, just added a couple of comments
Maybe some future improvements in other PR could be :
-
When users selects a chain from dialog box it gets added to select options of network dropdown to its corresponding group based on testnet or mainnet. Also we store in localstorage so that next time user visits abi.ninja he directly see in networks dropdown
-
Maybe some minor UI polish ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!!
could you please add a small condition to say locahost instead of foundry if chain id is 31337 :
abi.ninja/packages/nextjs/components/scaffold-eth/RainbowKitCustomConnectButton/index.tsx
Line 49 in baeec4e
{chain.name} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GJ Port!! Looking good to me! 🙌
When users selects a chain from dialog box it gets added to select options of network dropdown to its corresponding group based on testnet or mainnet. Also we store in localstorage so that next time user visits abi.ninja he directly see in networks dropdown
I really like this idea. Maybe this feature could evolve to "✏ Edit Chains" or similar, where user can select which chains to show in the dropdown, and we can add the "Add new chain" feature in that modal too.
Hey port could you also please resolve conflicts in |
Give me 15 minutes, I am implementing the save selected chains to localstorage feature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @portdeveloper , also noticed a small UX improvements we can do is when chain is selected and added in dropdown from modal. If you again open modal it shouldn't be present their.
And also we should ask Andrea if we can use some other icons for chains that are added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice Port! Thanks!
just cc @Pabl0cks and @carletex once for final UI/UX feel if something we should tweak in this PR itself, we can iterate more later and also created #117.
Here is vercel deployed link: https://abi-ninja-v2-r9zqeunq6-buidlguidldao.vercel.app/
I think the UI/UX feels good! But something is wrong when I search for contracts. Trying with Gitcoin address from mainnet: 0xde30da39c46104798bb5aa3fe8b9e0e1f348163f From the logs it seems like is trying to query for the address on Arbitrum instead: UPDATE:
|
Oh thanks @Pabl0cks I think simple works best here. Pushing the change, feel free to make any modifs if you feel like it! |
nice catch !! Just to be sure also checked at other reference if it will cause any problem else where it seems fine 🙌 Thanks @portdeveloper and Pablo fore review ! Merging this ! |
Description
Since #107 was too big, I decided to break the PR in two:
This is the PR that implements all chains that viem supports.
As all chains from viem includes localhost, I have:
Additional Information
Related Issues
Closes #{issue number}
Note: If your changes are small and straightforward, you may skip the creation of an issue beforehand and remove this section. However, for medium-to-large changes, it is recommended to have an open issue for discussion and approval prior to submitting a pull request.
Your ENS/address: