Use getsourcecode endpoint from etherscan api instead of anyabi+ proxy detection logic

[portdeveloper]

Description

This PR

-> Uses getsourcecode api, which can be found here: https://docs.etherscan.io/api-endpoints/contracts
-> Removes the use of anyabi and proxy detection logic

To-Do

• Need to update the tests accordingly
  (We probably need to add all those env vars to github actions for the tests to work, and i don't have access to that)

Related Issues

Fixes #141

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
abi-ninja-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 3, 2024 6:01am

[Pabl0cks]

AWESOME job @portdeveloper!!

Tested nicely with different use cases and is working nicely! And implementation contracts are working great now.

Just missing to verify one use case (custom chains). Tried using your custom chain example and is not working for me:

parex chain details:
chainId: 322202
rpc: https://mainnet-rpc.parex.network
verified contract: 0x6058518142C6AD506530F5A62dCc58050bf6fC28
block explorer: https://scan.parex.network/

I'm getting Address is not a contract, are you sure you are on the correct chain? message. Tried with 0x34f04Ed4550DC66798517C454e2ee7DF6B88f45d and i'm getting the "Decompile (beta)" / "Import ABI" options.

[portdeveloper]

@Pabl0cks Thanks for the review!

Unfortunately, parex network is down and Shiv found another chain:

  it("should add Viction as a custom chain and interact with a contract by submitting an ABI manually", () => {
    cy.visit("http://localhost:3000");
    cy.selectNetwork("Add custom chain");
    cy.get("#add-custom-chain-modal").should("be.visible");
    cy.addCustomChain({
      id: "88",
      name: "Viction",
      nativeCurrencyName: "VIC",
      nativeCurrencySymbol: "VIC",
      nativeCurrencyDecimals: "18",
      rpcUrl: "https://rpc.viction.xyz",
      blockExplorer: "https://tomoscan.io/",
    });
    cy.get("#react-select-container").should("contain", "Viction");
    cy.get('input[placeholder="Contract address"]').type("0x381B31409e4D220919B2cFF012ED94d70135A59e");
    cy.fixture("viction_abi").then(victionABI => {
      cy.importABI(JSON.stringify(victionABI));
    });
    cy.url().should("include", "/0x381B31409e4D220919B2cFF012ED94d70135A59e/88");
    cy.get(".loading-spinner", { timeout: 10000 }).should("not.exist");
    cy.interactWithMethod("balanceOf", "0xd8dA6BF26964aF9D7eEd9e03E53415D37aA96045");
  });

And if you use Viction, you successfully reach addressAbi tab and import an ABI manually and reach the interaction page.

[technophile-04]

Ohh don't know how I missed this PR, will try it over weekend 🙌

[Pabl0cks]

And if you use Viction, you successfully reach addressAbi tab and import an ABI manually and reach the interaction page.

TYSM! Approving the PR now 🙌

[technophile-04]

Tysm @portdeveloper!! Great find on getsourcode enpoint! removes a lot of burden and network request to check for proxies! Just tested it out looks good! Added a couple of small comments

---

Regarding GH actions tests now if someone outsider makes a PR to abi.ninja they would always fails since their fork/branch won't be able to access our variables.

A manual solution for now would be we(reviewer) run yarn cypress:run locally and see if that PR passes the test before merging. I think we had chat about it in TG and also tried digging about it technophile-04/abininja-fork@5a2a48b but it seems to doesn't work but yeah in long run it would be great if we get it solved not at all top-priority though

[technophile-04]

Just pushed a couple of commits(hacky) to fix the GH action, the problem seems even after adding those variables to github secrets they were not getting picked by nextjs so added a step where we echo .env.local inside packages/nexjts not the solution I am proud off :/ but yeah I think we should solve this too while tinkering with second part of #157 (review)

[portdeveloper]

@technophile-04 thanks for you feedback, fixed!

also about the automated tests problem, i wonder if playwright is easier to configure?

[technophile-04]

Tysm @portdeveloper !!