-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove extra footer #75
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch !! Tysm @portdeveloper, a small nitpick 😅 :
I think we lost the margin top on footer for home screen on small devices, maybe we add a margin bottom / space below to "Load contract" btn so that we can use generic MiniFooter
component their too?
Thanks for the feedback @technophile-04 ! Fixed, also changed the way the padding works on index, increased the bottom padding to make the footer look further apart from the bottom border. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicceee, its working great!! Tysm @portdeveloper 🙌!!
Description
In some resolutions, the mini footer is unclickable due to the og footer coming on top of it.
Before
msedge_zWNbvbqNEU.mp4
After
msedge_2sLZ8F3tgP.mp4
Additional Information
Related Issues
Closes #{issue number}
Note: If your changes are small and straightforward, you may skip the creation of an issue beforehand and remove this section. However, for medium-to-large changes, it is recommended to have an open issue for discussion and approval prior to submitting a pull request.
Your ENS/address: