Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra footer #75

Merged
merged 6 commits into from
Mar 25, 2024
Merged

Remove extra footer #75

merged 6 commits into from
Mar 25, 2024

Conversation

portdeveloper
Copy link
Member

Description

In some resolutions, the mini footer is unclickable due to the og footer coming on top of it.

Before

msedge_zWNbvbqNEU.mp4

After

msedge_2sLZ8F3tgP.mp4

Additional Information

Related Issues

Closes #{issue number}

Note: If your changes are small and straightforward, you may skip the creation of an issue beforehand and remove this section. However, for medium-to-large changes, it is recommended to have an open issue for discussion and approval prior to submitting a pull request.

Your ENS/address:

Copy link

vercel bot commented Mar 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
abi-ninja-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 4:51pm

@portdeveloper portdeveloper marked this pull request as draft March 23, 2024 18:16
Copy link
Member

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch !! Tysm @portdeveloper, a small nitpick 😅 :

Screenshot 2024-03-25 at 5 04 55 PM

I think we lost the margin top on footer for home screen on small devices, maybe we add a margin bottom / space below to "Load contract" btn so that we can use generic MiniFooter component their too?

@portdeveloper
Copy link
Member Author

Thanks for the feedback @technophile-04 !

Fixed, also changed the way the padding works on index, increased the bottom padding to make the footer look further apart from the bottom border.

Copy link
Member

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicceee, its working great!! Tysm @portdeveloper 🙌!!

@technophile-04 technophile-04 merged commit 0e28d65 into main Mar 25, 2024
3 checks passed
Pabl0cks added a commit that referenced this pull request Mar 28, 2024
@portdeveloper portdeveloper deleted the fix/unclickable-footer branch April 25, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants