New P2P node implementation #395
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimize/estimate gas
Ft/parse abi once
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the long-announced change to clean up p2p node information handling throughout the codebase.
Porting to
enode.Nodebrings support for ENR features to every place that deals with node information, but more work will be needed to actually start relaying node records across protocols. For now, most records handled in codeare unsigned records created through
enode.NewV4. Changes in devp2p and discovery will enable relaying signed records and updating them.The new p2p/enode package
The new package defines a type Node, which wraps a node record and provides access to common information such as IP address and ports as methods. This package is the new home of the enode URL parser and the node database.
Changes to existing code
The core of this change are the following replacements across the codebase:
Refs: ethereum/go-ethereum#17643