Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement eip-1186, eth_getProof #474

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

khangnt-coin98
Copy link

@khangnt-coin98 khangnt-coin98 commented Nov 5, 2024

#473
References:

Flowchart summary:
General

Notice:
Pending block tag support, when client call method, miner returns block with falsy value (block number 0x1400224ca20). Latest version of Geth should prevent calling with a “pending” block tag.

@khangnt-coin98 khangnt-coin98 marked this pull request as ready for review November 5, 2024 08:34
@imterryyy
Copy link
Collaborator

Please resolve conflict

@khangnt-coin98
Copy link
Author

Please resolve conflict

resolved

@khangnt-coin98
Copy link
Author

@imterryyy should we also implement blockhash support for this method?

@imterryyy
Copy link
Collaborator

yes, why not.

@khangnt-coin98
Copy link
Author

yes, why not.

this may result in many changes, and conflict to other apis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants