-
Notifications
You must be signed in to change notification settings - Fork 957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat[gen1][core] ENG-7238 remove query API and apiEndpoint field #3681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clyde-builderio
requested review from
samijaber
and removed request for
a team
October 25, 2024 10:16
🦋 Changeset detectedLatest commit: 811205d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
clyde-builderio
requested review from
teleaziz
and removed request for
a team
October 25, 2024 10:36
samijaber
reviewed
Oct 25, 2024
samijaber
approved these changes
Oct 30, 2024
samijaber
added a commit
to samijaber/builder
that referenced
this pull request
Nov 17, 2024
…eld (BuilderIO#3681)" This reverts commit f4fffe9.
samijaber
added a commit
that referenced
this pull request
Nov 17, 2024
This reverts commit f4fffe9 (#3681) and allows using `/query` again to fix React SDK. v6 (showing wrong symbol): ![CleanShot 2024-11-17 at 14 38 47@2x](https://github.com/user-attachments/assets/eeb0d228-0c7f-4d7a-881b-99c2d2e87355) v7.0.0-0 (dev) showing correct symbol: <img width="2192" alt="image" src="https://github.com/user-attachments/assets/6e314c4b-b2a2-4913-a0fb-5f43f9a34234"> https://builder-io.atlassian.net/browse/ENG-7483
Merged
samijaber
pushed a commit
that referenced
this pull request
Nov 17, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @builder.io/sdk@5.0.0 ### Major Changes - f12f43d: Breaking Change: Use `/query` instead of `/content` for API calls. This change fixes a symbol rendering issue introduced in <#3681>, which was included in the 4.0.0 release. ## @builder.io/react@7.0.0 ### Major Changes - f12f43d: Breaking Change: Use `/query` instead of `/content` for API calls. This change fixes a symbol rendering issue introduced in <#3681>, which was included in the 6.0.0 release. ### Patch Changes - Updated dependencies [f12f43d] - @builder.io/sdk@5.0.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sidmohanty11
pushed a commit
to sidmohanty11/builder
that referenced
this pull request
Dec 19, 2024
This reverts commit f4fffe9 (BuilderIO#3681) and allows using `/query` again to fix React SDK. v6 (showing wrong symbol): ![CleanShot 2024-11-17 at 14 38 47@2x](https://github.com/user-attachments/assets/eeb0d228-0c7f-4d7a-881b-99c2d2e87355) v7.0.0-0 (dev) showing correct symbol: <img width="2192" alt="image" src="https://github.com/user-attachments/assets/6e314c4b-b2a2-4913-a0fb-5f43f9a34234"> https://builder-io.atlassian.net/browse/ENG-7483
sidmohanty11
pushed a commit
to sidmohanty11/builder
that referenced
this pull request
Dec 19, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @builder.io/sdk@5.0.0 ### Major Changes - f12f43d: Breaking Change: Use `/query` instead of `/content` for API calls. This change fixes a symbol rendering issue introduced in <BuilderIO#3681>, which was included in the 4.0.0 release. ## @builder.io/react@7.0.0 ### Major Changes - f12f43d: Breaking Change: Use `/query` instead of `/content` for API calls. This change fixes a symbol rendering issue introduced in <BuilderIO#3681>, which was included in the 6.0.0 release. ### Patch Changes - Updated dependencies [f12f43d] - @builder.io/sdk@5.0.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove query API for Gen1 SDK
Objectives:
apiEndpoint
and the code that depends on this field as an input.Link to JIRA ticket:
https://builder-io.atlassian.net/browse/ENG-7238