Make to CTS #22
Merged
Make to CTS #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s.py file bc of conflict
kflemin
requested changes
May 29, 2024
| import logging | ||
| from pathlib import Path | ||
|
|
||
| import pandas as pd |
There was a problem hiding this comment.
I don't think this is added to the poetry file as a requirement yet...can you also make sure that you choose a version of pandas that match what is included with SEED?
There was a problem hiding this comment.
hm, I added it to the toml and its in the lock, am I missing something? seed doesn't seem to specific a pandas version, it requires https://github.com/SEED-platform/buildingid, which itself requires pandas, but it neither specifics or locks a pandas versions.
I can tell you I required this new version of BAE in seed locally and it worked. 🤷🏻
|
to document: we will lock the version of pandas to v2.2.2 to match SEED. Once that's done this will be ready to merge and release! thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The entry point is
building_sync_to_cts. ItAgency Designated Covered Facility IDto make facilities